https://bugzilla.redhat.com/show_bug.cgi?id=2176933 --- Comment #3 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity first. The spec is very tidy and sane. Suggestions bellow: > BuildRequires: %{py3_dist pygments} This should probably come generated from upstream. The setup.py has: install_requires=[ 'pygments >= 1.5' ], So %pyproject_buildrequires probably already generates this (including >= 1.5). > Summary: Accessible pygments themes This could be Summary: %{summary} > %pyproject_save_files a11y_pygments If the importable module is called a11y_pygments, consider adding %py_provides python3-a11y-pygments as well. In the spirit of https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_for_importable_modules > export PYTHONPATH=%{buildroot}%{python3_sitelib} You can use %{py3_test_envvars} instead, available on Fedora 38+ https://src.fedoraproject.org/rpms/python-rpm-macros/c/b6479253006cef572fb0cbe7ce001b3048f127b3?branch=rawhide I can do backports if you want me to. > python3 test/run_tests.py Please always use %{python3} instead of directly invoking python3. it makes no difference in Fedora, but it makes the spec portable to e.g. RHEL alternative Python version stacks. > %license LICENSE This is most likely redundant, but I have not yet built the package to verify. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2176933 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
