https://bugzilla.redhat.com/show_bug.cgi?id=2049808 Nikola Forró <nforro@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nforro@xxxxxxxxxx --- Comment #5 from Nikola Forró <nforro@xxxxxxxxxx> --- Here are some more important issues: > Name: %{appname}-2 I don't think this is a valid name. Packaging Guidelines say about packages with the same base name [1]: If the base package name does not end with a digit, the version MUST be directly appended to the package name with no intervening separator. > License: ASL 2.0 and MIT This should be: License: Apache-2.0 AND MIT You should also explicitly state in a comment which source files are under MIT (since majority of them are under Apache-2.0). > Patch0: awscli-2.patch Existence of this patch should be justified. The package doesn't build. It does build after updating to the latest upstream version (2.11.6) and removing the downstream patch and version cap of prompt-toolkit, but the test suite ends with: = 96 failed, 64530 passed, 4 skipped, 3 warnings, 97 errors in 518.31s (0:08:38) = [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#multiple -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2049808 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
