https://bugzilla.redhat.com/show_bug.cgi?id=2181779 --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to blinxen from comment #2) > Taking this review > > General comments: > > - Spec file was generated with rust2rpm and edited manually. > - All features / dependencies that depend on ring were dropped because of > limited architecture support [1]. Should be OK if the features are not > required by other crates. Yes, no crates that will depend on trust-dns-client use the features that depend on ring / rustls. These features are also already disabled in other packages for the trust-dns-* crates. > Questions: > > - You deactivated the check stage because of a missing `dev-dependency`. Is > there a reason why you did not just package the missing dependency? I plan to package tracing-subscriber in the near future, but tracing-subscriber also has a few dependencies that are not packaged yet. I haven't gotten around to packaging all of them yet, and since tracing-subscriber is only a dependency for running tests of a few crates, it was not high priority. However, it turns out that the dependency on tracing-subscriber is entirely unused in this crate (?), so I've just removed it and enabled tests. Updated spec and SRPM is available behind the same links. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2181779 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
