https://bugzilla.redhat.com/show_bug.cgi?id=2182479 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |POST Doc Type|--- |If docs needed, set a value --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Looks good to me, though you might want to explicitly exclude some files from the package (i.e. by generating this patch with "rust2rpm -p"): ``` --- itoap-1.0.1/Cargo.toml 2021-02-18T16:50:24+00:00 +++ itoap-1.0.1/Cargo.toml 2023-03-28T19:56:56.117524+00:00 @@ -21,6 +21,7 @@ categories = ["value-formatting"] license = "MIT" repository = "https://github.com/Kogia-sima/itoap"; +exclude = ["/bench.png", "/codecov.yml", "/rustfmt.toml"] [package.metadata.docs.rs] all-features = true rustdoc-args = ["--cfg", "docsrs"] ``` A patch like this should also be acceptable by the upstream project, since these files are only useful as docs or for upstream development / CI. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification ("MIT") and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2182479 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
