https://bugzilla.redhat.com/show_bug.cgi?id=2181025 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (Apache-2.0 AND BSD-3-Clause) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Looks good to me. According to the ticket linked in the initial comment, it seems the license of this crate should be "(Apache-2.0 OR BSD-3-Clause) AND BSD-3-Clause" as well? Either way, the current license string is "Apache-2.0 AND BSD-3-Clause", which should be fine for now (just with "less details") - and license texts for both licenses are included as well. Just include a comment with the link to the upstream issue in the spec file, so we don't forget about it. # https://github.com/rust-vmm/linux-loader/issues/136 === Note that the crate does not seem to build correctly across all architectures: https://koji.fedoraproject.org/koji/taskinfo?taskID=99237932 - x86_64: builds, tests pass - aarch64: builds, tests pass - i686: builds, some tests fail (harmless failures in tests generated by bindgen) - s390x: builds, some tests pass, some doctests fail to compile - s390x: builds, some tests pass, some doctests fail to compile If I remember correctly, you said that firecracker is only supported on x86_64 and aarch64? If that is the case, I would add "ExclusiveArch: x86_64 aarch64" to this package, with a comment that firecracker only supports these architectures. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2181025 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
