https://bugzilla.redhat.com/show_bug.cgi?id=2182311 --- Comment #2 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- > Source0: %{url}%{version}/archive/refs/tags/v1.6.0.tar.gz Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz > BuildRequires: qt5-qtbase-private-devel Private API has no ABI compatibility, so you must pin to exact Qt version: %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}} > %cmake -G Ninja Please add the correct build type, or fallback to Debug will be used implicitly: %cmake -G Ninja -DCMAKE_BUILD_TYPE=Release > rm -r %{buildroot}%{_datadir}/doc Why removing docs? I think they can be packaged to a -docs noarch subpackage. > %{_libdir}/libkddockwidgets.so.* You must include soversion to prevent accidental bumps: %{_libdir}/libkddockwidgets.so.1* -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2182311 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
