https://bugzilla.redhat.com/show_bug.cgi?id=2181686 --- Comment #5 from Derek <djw8605@xxxxxxxxx> --- (In reply to Steve Traylen from comment #2) > > Comments reading through the .spec file and source: > > 1. Requires: python3-jwt >= 1.6.1 > Requires: python3-cryptography > > These are not needed as computed anyway. > Done > > which raises the point that I expect that setuptools is not needed runtime > so try and get rid of that is possible. I'll look into it, but I think you are right, setuptools isn't needed. Since I am the upstream, I can make these changes. > > 2. export PYTHONPATH="%{buildroot}%{python3_sitelib}" > (cd tests/ && %{__python3} -m pytest --verbose -ra .) > > Can the %pytest macros be used for that ? It does something like that. Done, good suggestion. > > 3. src/scitokens/urltools.py seems to MIT license and is a bundling of > https://github.com/itzik-h/urltools Can this be unbundled and a new package > for urltools be created? > I see you have submitted this package. Thank you very much! > > And some more optional stuff: > > 1. Package is using the old macros - The text in the newer guidelines implied that I should use the older macros if targeting EPEL8, which I certainly am. > > 2. Use %pypi_source macro for source URL? Done. Some of these changes require a new release of scitokens, which takes a bit more time to produce. How do you want to handle these changes, especially the urltools change. Can we move forward here while we will change scitokens to use the urltools package when it is accepted into EPEL? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2181686 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
