[Bug 2165399] Review Request: obs-studio - Open Broadcaster Software Studio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2165399



--- Comment #12 from Davide Cavalca <davide@xxxxxxxxxxxx> ---
Other issues from a quick review:

[ ]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/512x512,
     /usr/share/icons/hicolor/scalable,
     /usr/share/icons/hicolor/scalable/apps,
     /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor,
     /usr/share/icons/hicolor/256x256,
     /usr/share/icons/hicolor/256x256/apps,
     /usr/share/icons/hicolor/512x512/apps

You're probabily missing a runtime dep for these

[!]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 11335680 bytes in /usr/share obs-
     studio-29.1.0~git202303261743.ad859a3-0.fc39.1.aarch64.rpm:11335680
     See:
    
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines

And from rpmlint, these should be deleted

obs-studio.aarch64: E: zero-length
/usr/share/obs/obs-plugins/decklink-captions/.keepme
obs-studio.aarch64: E: zero-length
/usr/share/obs/obs-plugins/decklink-output-ui/.keepme
obs-studio.aarch64: E: zero-length
/usr/share/obs/obs-plugins/linux-pipewire/.gitkeep

and these are probably fine but might warrant a comment or a lint override:

obs-studio-libs.aarch64: W: devel-file-in-non-devel-package
/usr/lib64/libobs-frontend-api.so
obs-studio-libs.aarch64: W: devel-file-in-non-devel-package
/usr/lib64/libobs-opengl.so
obs-studio-libs.aarch64: W: devel-file-in-non-devel-package
/usr/lib64/libobs-scripting.so
obs-studio-libs.aarch64: W: devel-file-in-non-devel-package
/usr/lib64/libobs.so
obs-studio-libs.aarch64: W: devel-file-in-non-devel-package
/usr/lib64/libobsglad.so


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2165399
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux