https://bugzilla.redhat.com/show_bug.cgi?id=2181035 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks! One minor problem and one bigger problem remain: 1. I'm not sure if marking directories as %doc even works ... I would replace this: "%doc %{crate_instdir}/images" with this: "%doc %{crate_instdir}/images/*" Marking "src/allocation_engine/DESIGN.md" as %doc isn't really necessary, but it doesn't hurt either. 2. The project's license (both the upstream one and the fixed one) specify the BSD-3-Clause license, but the license text for this license is not included - neither in published crates, nor in the upstream project's repository. This seems like an oversight. The BSD-3-Clause license also requires that (re)distributed sources contain a copy of the license notice and license text: https://choosealicense.com/licenses/bsd-3-clause/ The 2. issue is a blocker for now ... please notify upstream about the missing license text. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2181035 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
