[Bug 2181022] Review Request: rust-device_tree - Reads and parses Linux device tree images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2181022



--- Comment #8 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
This is not doing what you think it is:

`#[cfg(not(test))]`

This means "include this code only if we're not building tests" (i.e. the code
will not end up in test binaries, but in the actual library).

You need to remove the tests entirely. I don't think there's something like an
`#[cfg(false)]` attribute.

Other than that, yes, I agree, this crate looks fishy, and dropping it is
probably wise.
Feel free to close this ticket as CLOSED/NOTABUG.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2181022
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux