[Bug 2149953] Review Request: rust-cfonts - Sexy ANSI fonts for the console

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2149953



--- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
> Apart adding %doc %{crate_instdir}/README.md, should we ask upstream to fix or enhance something in the Cargo.toml file in order to avoid to manually include the LICENSE file?

Yes. They are distributing sources that don't include their own license file.
:(

The list of files here needs to include a "LICENSE" file:
https://github.com/dominikwilkowski/cfonts/blob/released/rust/Cargo.toml#L14

And there needs to be a copy (or symlink) of the file in the "rust" directory.
Please report this with the upstream project.

Also note that while the project's Cargo.toml references "../README.md" as its
"readme" file, this is not really defined behaviour unless the "README.md" file
is also included in the list of files to "include".

---

Additionally, the "%package -n %{crate}" subpackage is still missing a License
tag that contains the licenses that are printed by %cargo_license_summary.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2149953
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux