https://bugzilla.redhat.com/show_bug.cgi?id=2149953 blinxen <h-k-81@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |h-k-81@xxxxxxxxxxx Flags| |fedora-review? CC| |h-k-81@xxxxxxxxxxx --- Comment #4 from blinxen <h-k-81@xxxxxxxxxxx> --- Taking this review Some comments / issues with the package: - The upstream project does not include a license file in `Cargo.toml`. I can see that you add it manually but it would be nice if you could push the change to upstream. Maybe by specifying `license-file` [1]?. - The license path for the `devel` package is wrong. It should be `%license %{crate_instdir}/LICENSE`. - `rust2rpm` always adds the `%doc` directive to `devel` packages. I am not sure if this is actually required as I couldn't find anything about it in the guidelines but I think adding it shouldn't hurt. Something like `%doc %{crate_instdir}/README.md` [1] https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2149953 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
