https://bugzilla.redhat.com/show_bug.cgi?id=2181686 --- Comment #2 from Steve Traylen <steve.traylen@xxxxxxx> --- Hi Derek, Comments reading through the .spec file and source: 1. Requires: python3-jwt >= 1.6.1 Requires: python3-cryptography These are not needed as computed anyway. rpm -qp --requires /var/lib/mock/fedora-rawhide-x86_64/result/python3-scitokens-1.7.4-1.fc39.noarch.rpm | grep 3. python(abi) = 3.11 python3.11dist(cryptography) python3.11dist(pyjwt) >= 1.6.1 python3.11dist(setuptools) which raises the point that I expect that setuptools is not needed runtime so try and get rid of that is possible. 2. export PYTHONPATH="%{buildroot}%{python3_sitelib}" (cd tests/ && %{__python3} -m pytest --verbose -ra .) Can the %pytest macros be used for that ? It does something like that. 3. src/scitokens/urltools.py seems to MIT license and is a bundling of https://github.com/itzik-h/urltools Can this be unbundled and a new package for urltools be created? And some more optional stuff: 1. Package is using the old macros - https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/ , Maybe switch to the new pyproject macros - https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ Choice is free however. 2. Use %pypi_source macro for source URL? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2181686 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
