https://bugzilla.redhat.com/show_bug.cgi?id=2181029 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |decathorpe@xxxxxxxxx Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package looks good to me, just two comments: 1. You can partially automate generating patches for Cargo.toml files with "rust2rpm -p". This also ensures that any changes to Cargo.toml that can affect contents of generated spec files are taken into account correctly (i.e. cargo metadata that's used for generating the spec file is loaded *after* the patch is applied). 2. When I previously worked on this package (before it was removed from Fedora 37+), I was able to run most tests: https://src.fedoraproject.org/rpms/rust-userfaultfd-sys/blob/f36/f/rust-userfaultfd-sys.spec#_91-92 It might be worth investigating if skipping this one test still makes the rest of the test suite pass. ===== Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (test suite is disabled with justification) - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === You can now proceed with filing the unretirement request: https://pagure.io/releng/new_issue (select package_unretirement template in issue "Types" dropdown) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2181029 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
