https://bugzilla.redhat.com/show_bug.cgi?id=2181021 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Two comments: 1. The latest version is 2.0.0, but you're packaging 1.0.0. Please confirm that this is intentional. 2. The package ships a "crc64" package that contains /usr/bin/crc64. There doesn't appear to be any other package in Fedora that provides this binary, so it should be fine. Since this crate has no dependencies it should also be correct from a license standpoint (i.e. you don't need to list and take into account licenses of statically linked dependencies if there are none). But if you don't need the /usr/bin/crc64 binary (i.e. firecracker only uses the Rust library and not the "crc64" executable), you could drop it from the package, it would make builds a bit faster. For example, this patch would do it ("rust2rpm -p" is your friend): ``` --- crc64-1.0.0/Cargo.toml 2016-01-07T03:02:35+00:00 +++ crc64-1.0.0/Cargo.toml 2023-03-23T14:01:59.277230+00:00 @@ -7,12 +7,8 @@ homepage = "https://github.com/badboy/crc64-rs"; license = "BSD-3-Clause" readme = "README.md" +autobins = false [lib] name = "crc64" path = "src/lib.rs" - -[[bin]] -name = "crc64" -path = "src/main.rs" -doc = false ``` -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2181021 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
