[Bug 2173178] Review Request: kde-inotify-survey - inotify monitor for kde

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2173178



--- Comment #13 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
Further issues from fedora-review 0.9.0 (6761b6c):
1)
Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/dbus-1,
     /usr/lib64/qt5/plugins/kf5/kded, /usr/share/polkit-1,
     /usr/share/polkit-1/actions
These directories should owned by dependencies: 
https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/
Maybe explicit requires should be added to the spec?

2)
kde-inotify-survey.src: W: inconsistent-file-extension
kde-inotify-survey-1.0.0.tar.zst
$ rpmlint -e inconsistent-file-extension
inconsistent-file-extension:
The file name extension indicates a different compression format than what is
actually used (as checked by file(1)).
$ file kde-inotify-survey-1.0.0.tar.zst 
kde-inotify-survey-1.0.0.tar.zst: Zstandard compressed data (v0.8+), Dictionary
ID: None

Is this a bug as zst seems to be supported?

3)
kde-inotify-survey.x86_64: E: communication not allowed
/usr/share/dbus-1/system.d/org.kde.kded.inotify.conf
Maybe  a dbus activation file is needed?
https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#activation_dbus

4)
There are multiple licenses used, in particular GPL3, GPL2, LGPL2.1 and CCO,
probably some of these should be
added and a license breakdown given.

5) OpenSUSE seems to check signatures:
https://build.opensuse.org/package/show/KDE:Applications/kde-inotify-survey
Could this be done as well?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2173178
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux