https://bugzilla.redhat.com/show_bug.cgi?id=2180450 --- Comment #11 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review: > License: GPLv2 The license is "GPL-2.0-or-later" from what I see in the sources. > Source0: %{url}/archive/refs/tags/%{name}-%{version}.tar.gz The format should be "%{url}/archive/%{name}-%{version}.tar.gz" > %{_sysconfdir}/dbus-1/system.d/org.containers.hirte.conf This should be installed into "%{_datadir}/dbus-1/system.d" > %{_sysconfdir}/dbus-1/system.d/org.containers.hirte.Agent.conf Ditto. > %setup -c -q Shouldn't this be just "%autosetup"? And why are we creating a directory ("-c")? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2180450 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
