https://bugzilla.redhat.com/show_bug.cgi?id=2179075 Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vitaly@xxxxxxxxxxxxxx --- Comment #3 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- > Name: lib%{sname} Name: prometheus-cpp > %global _hardened_build 1 All builds are hardened by default. You can safely remove this line. > %undefine _debugsource_packages > %undefine _debuginfo_subpackages Debuginfo must be generated. Remove these lines. > %package -n %{name}1 Why adding 1 suffix here? > %setup -q -n %{sname}-%{version} After changing Name, simply use this: %autosetup > %{cmake} . \ Remove dot. > export GCC_COLORS= > export VERBOSE=1 Can be removed. %cmake will automatically enable verbose mode. > %cmake_build %{?_smp_mflags} Remove %{?_smp_mflags}. > %clean Legacy and prohibited. Must be removed. > %{_libdir}/%{name}-*.so.* You must add soversion here. > %dir %{_includedir}/prometheus > %{_includedir}/prometheus/* Should be simplified: %{_includedir}/prometheus/ > %dir %{_libdir}/cmake/%{sname} > %{_libdir}/cmake/%{sname}/%{sname}*.cmake Should be simplified: %{_libdir}/cmake/%{name} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2179075 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
