[Bug 2119983] Review Request: c-icap - An implementation of an ICAP server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2119983



--- Comment #60 from Frank Crawford <frank@xxxxxxxxxxxxxxxxxx> ---
Oh, looking through the rpmlint output attached to the review, there are a
batch of little items that I see need fixing.

> c-icap.x86_64: E: logrotate-user-writable-log-dir /var/log/c-icap c-icap:c-icap 0750

This needs an
> su c-icap c-icap
in c-icap.logrotate

> c-icap-libs.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libicapapi.so.0.0.1 SSL_CTX_set_cipher_list

This is trickier, but covered in
https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ and
effectively says the default be
> PROFILE=SYSTEM
in the c-icap-conf but I'm not sure how that can be added into there.

And also:
> c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/dnsbl_tables.so /lib64/libatomic.so.1

(and many more) may be covered by
https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency

And finally:
> c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so CI_DEBUG_LEVEL	(/usr/lib64/c_icap/dnsbl_tables.so)

which I'm not sure, as that looks to be well define.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux