Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Handler-YAWriter - Yet another Perl SAX XML Writer https://bugzilla.redhat.com/show_bug.cgi?id=426829 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-12-27 22:28 EST ------- Review: + package builds in mock (rawhide). + rpmlint is silent for SRPM and for RPM. + source files match upstream url c7ba2a828a284d6a13ea6fbbfec2b162 XML-Handler-YAWriter-0.23.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test output is 1..5 ok 1 ok 2 ok 3 ok 4 ok 5 ok 6 ok 7 ok 8 +exit 0 + Package perl-XML-Handler-YAWriter-0.23-3.fc9 -> Provides: perl(XML::Handler::YAWriter) Requires: /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(IO::File) perl(XML::Handler::YAWriter) perl(XML::Parser::PerlSAX) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review