https://bugzilla.redhat.com/show_bug.cgi?id=2177855 --- Comment #4 from Mattia Verga <mattia.verga@xxxxxxxxx> --- (In reply to Petr Pisar from comment #3) > TODO: Upstream uses lowercase libxisf name in the release archives. I > suggest changing a name of this package to the lowercase variant > <https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ > #_general_naming>. It's similar to OpenSSH software which is packages as > openssh RPM. > > FIX: If the source archive is not publicly available, move the source > address into a comment and only keep the file name in Source0 value. > FIX: If the 0.2.0 version has not yet been released and this archive is only > a prerelease, then follow > <https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ > #_prerelease_versions> to change release value accordingly. > I've fixed the source URL as requested, gitea uses to rename the file on download, so I put the link URL as comment and just the file name in Source0. Version 0.2.0 is not listed in the "released" section, but is present in the tags list. I don't have a strong preference between uppercase and lowercase name, but considering the source file and mostly of the produced file are using the uppercase variant and considering that packaging guidelines now changed to use SHOULD instead of MUST be lowercase, I'd like to stay with the uppercase variant name. > Licenses found in the sources archive: > > debian/copyright: GPL-3.0-or-later > libxisf.cpp: GPL-3.0-or-later > libxisf.h: GPL-3.0-or-later > libXISF_global.h: GPL-3.0-or-later > LICENSE: GPL-3.0 text > lz4/: BSD-2-Clause > pugixml/: MIT > README.md: GPL-3.0-only (! this looks like an oversight by upstream) > test/main.cpp: GPL-3.0-or-later > utils.cpp: GPL-3.0-or-later > variant.cpp: GPL-3.0-or-later > zlib/: Zlib AND BSL-1.0 > > FIX: Add "GPL-3.0-only" to the license tag and ask upstream to clarify the > license declaration found in REAMDE.md. "Licensed under GPLv3" means > "GPL-3.0-only". Not "GPL-3.0-or-later" as it was probably intended. I've contacted upstream maintainer and they already updated the README.md file to use "GPLv3 or later". Let me know if you you think it is needed to backport the modified README.md. > > TODO: Constrain "cmake" build-dependency with ">= 3.14" (CMakeLists.txt:1). > TODO: Explicitly enable building shared libraries with > "-DBUILD_SHARED_LIBS=ON" (CMakeLists.txt:11). Done. Spec URL: https://mattia.fedorapeople.org/libXISF/libXISF.spec SRPM URL: https://mattia.fedorapeople.org/libXISF/libXISF-0.2.0-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2177855 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
