[Bug 2176241] Review Request: golang-github-zcalusic-sysinfo - Sysinfo is a Go library providing Linux OS / kernel / hardware system information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2176241



--- Comment #18 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
I'm sorry, but I don't understand what you want to achieve. 

The spec doesn't need this part:

> ## START: Set by rpmautospec
> ## (rpmautospec version 0.3.5)
> ## RPMAUTOSPEC: autorelease, autochangelog
> %define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
>     release_number = 1;
>     base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
>     print(release_number + base_release_number - 1);
> }%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
> ## END: Set by rpmautospec

I guess this is an old requirement that is not needed anymore. Where are you
getting this block from? And why are you using it?

> * Tue Mar 14 2023 Link Dupont <link@xxxxxxxxxxx> - 0.9.5-1
> - Intitial package

Why do you add an entry to changelog if you plan to use %autochangelog ?

Both things are not done by default by go2rpm so I guess you're adding them
after or you're post-processing the spec somehow, but it's not required.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176241
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux