https://bugzilla.redhat.com/show_bug.cgi?id=2176342 --- Comment #3 from Link Dupont <link@xxxxxxxxxxx> --- (In reply to Jiri Hnidek from comment #2) > Why do you specify build dependencies for dbus-devel package using this? > > BuildRequires: pkgconfig(dbus-1) > > Why don't you use just this? > > BuildRequires: dbus-devel Current Fedora packaging guidelines prefer using pkg-config BuildRequires: https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/. In addition, the rationale given in the "Rationale" section in the guidelines is accurate for this package. > When I tried to build binary RPM from the latest spec file and src.rpm, then > I got following errors: > > > [jhnidek@thinkpad-p1 SPECS]$ rpmbuild -bb > ./yggdrasil-worker-package-manager.spec > setting SOURCE_DATE_EPOCH=1678752000 > Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.MlEfRr > + umask 022 > + cd /home/jhnidek/rpmbuild/BUILD > + cd /home/jhnidek/rpmbuild/BUILD > + rm -rf yggdrasil-worker-package-manager-0.2.0 > + /usr/lib/rpm/rpmuncompress -x > /home/jhnidek/rpmbuild/SOURCES/yggdrasil-worker-package-manager-0.2.0.tar.gz > + STATUS=0 > + '[' 0 -ne 0 ']' > + cd yggdrasil-worker-package-manager-0.2.0 > + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . > + rm -fr > /home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/vendor > + [[ ! -e > /home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build/ > bin ]] > + install -m 0755 -vd > /home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build/ > bin > install: creating directory > '/home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build' > install: creating directory > '/home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build/ > bin' > + export > GOPATH=/home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/ > _build:/usr/share/gocode > + > GOPATH=/home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/ > _build:/usr/share/gocode > + [[ ! -e > /home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build/ > src/github.com/redhatinsights/yggdrasil-worker-package-manager ]] > ++ dirname > /home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build/ > src/github.com/redhatinsights/yggdrasil-worker-package-manager > + install -m 0755 -vd > /home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build/ > src/github.com/redhatinsights > install: creating directory > '/home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build/ > src' > install: creating directory > '/home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build/ > src/github.com' > install: creating directory > '/home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build/ > src/github.com/redhatinsights' > + ln -fs /home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0 > /home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build/ > src/github.com/redhatinsights/yggdrasil-worker-package-manager > + cd > /home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/_build/ > src/github.com/redhatinsights/yggdrasil-worker-package-manager > + RPM_EC=0 > ++ jobs -p > + exit 0 > Executing(%generate_buildrequires): /bin/sh -e /var/tmp/rpm-tmp.yWi6Ld > + umask 022 > + cd /home/jhnidek/rpmbuild/BUILD > + cd yggdrasil-worker-package-manager-0.2.0 > + > GOPATH=/home/jhnidek/rpmbuild/BUILD/yggdrasil-worker-package-manager-0.2.0/ > _build:/usr/share/gocode > + GO111MODULE=off > + golist --imported --package-path > github.com/redhatinsights/yggdrasil-worker-package-manager --template > 'golang({{.}})\n' --with-tests --skip-self > + RPM_EC=0 > ++ jobs -p > + exit 0 > error: Failed build dependencies: > golang(git.sr.ht/~spc/go-log) is needed by > yggdrasil-worker-package-manager-0.2.0-1.fc37.x86_64 > golang(github.com/google/uuid) is needed by > yggdrasil-worker-package-manager-0.2.0-1.fc37.x86_64 > golang(github.com/peterbourgon/ff/v3) is needed by > yggdrasil-worker-package-manager-0.2.0-1.fc37.x86_64 > golang(github.com/peterbourgon/ff/v3/fftoml) is needed by > yggdrasil-worker-package-manager-0.2.0-1.fc37.x86_64 > golang(github.com/redhatinsights/yggdrasil/ipc) is needed by > yggdrasil-worker-package-manager-0.2.0-1.fc37.x86_64 > golang(github.com/redhatinsights/yggdrasil/worker) is needed by > yggdrasil-worker-package-manager-0.2.0-1.fc37.x86_64 > golang(github.com/sgreben/flagvar) is needed by > yggdrasil-worker-package-manager-0.2.0-1.fc37.x86_64 > golang(github.com/zcalusic/sysinfo) is needed by > yggdrasil-worker-package-manager-0.2.0-1.fc37.x86_64 > Wrote: > /home/jhnidek/rpmbuild/SRPMS/yggdrasil-worker-package-manager-0.2.0-1.fc37. > buildreqs.nosrc.rpm If you're going to build the RPM locally using rpmbuild, you'll need to manually install the build requirements first. You can express the installation requirement to dnf in the form of the golang() pattern like so: dnf install 'golang(git.sr.ht/~spc/go-log)', and the RPM that Provides: that pattern will be resolved to by dnf. I suggest building the RPM using `mock` or `fedpkg` though; it will resolve the build requirements for you automatically and install them into the buildroot, rather than onto your local host directly. Currently, this package is still blocked by the inclusion of golang(github.com/zcalusic/sysinfo). That RPM is still under review in RHBZ#2176241. If you want to test building this RPM, you'll need to install golang-github-zcalusic-sysinfo-devel from my COPR for the time being. https://copr.fedorainfracloud.org/coprs/linkdupont/reviews/build/5641494/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2176342 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
