https://bugzilla.redhat.com/show_bug.cgi?id=2177572 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to Yaakov Selkowitz from comment #2) > Package Review > ============== > > NOTES: > * Does it make sense to carry forward RPMFusion's %changelog? I didn't completely write this package spec from scratch, so yes, I think so. That's the easy way to ensure attribution is preserved. > * Sources are marked GPL-2.0-or-later but COPYING is GPL3 (probably due to > autotools) I can file a ticket with upstream to put the right COPYING file and drop it from the package for now. > * WRT files-duplicate warning, the icon copying (and hence the use of > hicolor-icon-theme and %_datadir/icons) could be removed from the RPM build > and handled solely in the flatpak build with cleanup-commands. I'd prefer to leave this alone for the rpm build. I could file a ticket asking them to update their icon handling though. > * Use of AC_PROG_LIBTOOL doesn't bother me. > Meh. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2177572 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
