https://bugzilla.redhat.com/show_bug.cgi?id=2115560 --- Comment #3 from Petr Menšík <pemensik@xxxxxxxxxx> --- Even include-only C++ libraries are *-devel packages. I understand that primary goal might be building Mesa with it, but it should follow general rules where possible. I do not think there is any reason to not move headers to devel subpackage. Header only libraries have their own section [1]. I think that pretty much applies to those libraries as well. There is also special section for static libraries [2], which are used in this package too. That also does not pass in current package. In any case, noarch package cannot contain compiled library, be it static or dynamic. It must have own architecture package, compiled for any architecture where it may work. I just guess that might be just x86_64 and aarch64 architectures. As for the pkg-config file, it just requires library -lDirectX-Guids. It seems to me there is no reason for it to not be shared. Except it would need versioning in that case implemented. I think your plan for Mesa does not pass [3]. If you insist on using static libraries as is common on windows, it has to be at least packaged as valid static library. It required exception from Packaging comitee before, I have not seen any link to that. The main point might be building mesa, but this package can be the only package of DirectX-Headers in Fedora. So it should be as general as possible. If other project needs it for something, it should be able to use it too. As for tests, not sure what do they need. If they can pass only on actual WSL builder and not in common builder, consider having %bcond_with check disabled by default. But may it allow fedpkg local --with check to build it including tests. %bcond_with check ... %check %if %{with check} test/DirectX-Headers-Test %endif 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries 2. https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries 3. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_statically_linking_executables -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2115560 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
