[Bug 2176241] Review Request: golang-github-zcalusic-sysinfo - Sysinfo is a Go library providing Linux OS / kernel / hardware system information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2176241



--- Comment #8 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
> %license LICENSE cpiud-LICENSE

You've a typo in cpiud and thus fails to build.

Checking upstream package, I see this spec builds and installs cmd/sysinfo
binary. I understand that it's a test cmd to verify the library, but I'm not
sure if it has any benefit for users. If it's not a requirement then I'll
rather go with the package being a devel package only, and these parts could be
removed:

> (...)
> %build
> for cmd in cmd/* ; do
>   %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
> done
> (...)
> install -m 0755 -vd                     %{buildroot}%{_bindir}
> install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/
> (...)
> %files
> %license LICENSE cpiud-LICENSE
> %doc README.md
> %{_bindir}/*

But this line would be required:

> %global debug_package %{nil}

You can check package `golang-github-cloudflare-circl` as example.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176241
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux