[Bug 2177305] Review Request: civetweb - Embedded C/C++ web server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2177305



--- Comment #3 from Kaleb KEITHLEY <kkeithle@xxxxxxxxxx> ---
(In reply to Jakub Kadlčík from comment #2)
> Copr build:
> https://copr.fedorainfracloud.org/coprs/build/5626276
> (succeeded)
> 
> Review template:
> https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-
> review-2177305-civetweb/fedora-rawhide-x86_64/05626276-civetweb/fedora-
> review/review.txt
> 
> Please take a look if any issues were found.

LGTM. The 

...
[!]: Reviewer should test that the package builds in mock.
[!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
     Note: Found : Vendor: The civetweb developers
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_tags_and_sections
...

I had already found in my run of fedora-review
(https://bugzilla.redhat.com/show_bug.cgi?id=2177305#c1) and fixed in the .spec
in https://kkeithle.fedorapeople.org/civetweb/civetweb.spec, referenced in
https://bugzilla.redhat.com/show_bug.cgi?id=2177305#c0

and it does build in mock, so...


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2177305
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux