[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2176394



--- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Initial spec review:

> %{!?_without_caca:BuildRequires:  libcaca-devel}
> %{!?_without_lirc:BuildRequires:  lirc-devel}

We can drop the conditional goop here since it's available everywhere xine-lib
is (EPEL9 and Fedora)

> %if 0%{!?_without_lirc}
> export LIRC_CFLAGS="-llirc_client"
> export LIRC_LIBS="-llirc_client"
> %endif

Ditto for here too.

> %if 0%{?rhel} && 0%{?rhel} < 8
> %post
> # Mime type
> update-desktop-database &> /dev/null || :
> update-mime-database %{_datadir}/mime &> /dev/null || :
> # Icon cache
> touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
> 
> %postun
> # Mime type
> update-desktop-database &> /dev/null || :
> update-mime-database %{_datadir}/mime &> /dev/null || :
> # Icon cache
> if [ $1 -eq 0 ] ; then
>     touch --no-create %{_datadir}/icons/hicolor &>/dev/null
>     gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> fi
> 
> %posttrans
> gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> %endif

We can drop all this since this package can't be built on anything older than
EPEL 9.

> %{!?_without_caca:%{_bindir}/cacaxine}

We can drop the conditional goop here since it's available everywhere xine-lib
is (EPEL9 and Fedora)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux