https://bugzilla.redhat.com/show_bug.cgi?id=2176391 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > Requires(post): info > Requires(preun): info This is only needed for EL7. EL8 and newer have file triggers so this should be dropped for them. > find $RPM_BUILD_ROOT -type f -name "*.la" -exec rm -f {} ';' This should be %{buildroot} for consistency > %post libs -p /sbin/ldconfig > %postun libs -p /sbin/ldconfig This is only needed for EL7. If you want to have EL7 compatibility, please switch to "%ldconfig_scriptlets libs" instead, so it becomes a no-op on EL8+ and Fedora. > %post > for infofile in vcdxrip.info vcdimager.info vcd-info.info; do > /sbin/install-info %{_infodir}/${infofile} %{_infodir}/dir 2>/dev/null || : > done > > %preun > if [ $1 -eq 0 ]; then > for infofile in vcdxrip.info vcdimager.info vcd-info.info; do > /sbin/install-info --delete %{_infodir}/${infofile} %{_infodir}/dir \ > 2>/dev/null || : > done > fi This is only needed for EL7. EL8 and newer have file triggers so this should be dropped for them. > %{_bindir}/* > %{_mandir}/man1/* This kind of globbing is not explicit/specific enough, there's no way to tell if the package may add conflicting binaries. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2176391 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
