Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Tidy - Tidy indenting of XML documents https://bugzilla.redhat.com/show_bug.cgi?id=426645 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-12-27 00:47 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 8bafc2d11f95c403b3a7d732c5ed494d XML-Tidy-1.2.54HJnFa.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test output is t/00small.....ok t/01medium....ok t/02large.....ok t/03prune.....ok All tests successful. Files=4, Tests=60, 0 wallclock secs ( 0.45 cusr + 0.06 csys = 0.51 CPU) + Package perl-XML-Tidy-1.2.54HJnFa-3.fc9 -> Provides: perl(XML::Tidy) = 1.2.54 Requires: /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(Math::BaseCnv) perl(XML::XPath) perl(XML::XPath::XMLParser) perl(base) perl(strict) perl(vars) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review