https://bugzilla.redhat.com/show_bug.cgi?id=2175818 --- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > Version: 2.4.0 > %if %{with_snapshot} > Release: %autorelease -p -s %{gitdate}git%{shortcommit} > %else > Release: %autorelease Please move the snapshot versioning to "Version", like so: "2.4.0%{?with_snapshot:^%{gitdate}git%{shortcommit}}" Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > -DINPUTLEAP_BUILD_TESTS=OFF \ > -DINPUTLEAP_USE_EXTERNAL_GTEST=false We do have gtest-devel for this... > desktop-file-install --delete-original \ > --dir %{buildroot}%{_datadir}/applications \ > --set-icon=%{_datadir}/icons/hicolor/scalable/apps/%{name}.svg \ > %{buildroot}%{_datadir}/applications/%{name}.desktop I looked at the original desktop file, and I don't see a reason to rewrite the file? https://github.com/input-leap/input-leap/blob/master/res/input-leap.desktop Can we just replace this with desktop-file-validate in %check? Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage We also want validation of the AppStream metainfo file. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175818 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
