[Bug 2174384] Review Request: contour-terminal - Modern C++ Terminal Emulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2174384



--- Comment #11 from Felix Wang <topazus@xxxxxxxxxxx> ---
(In reply to Felix Wang from comment #8)
> problem a, b an d have been fixed by adding Requires of hicolor-icon-theme,
> kf5-kservice, kf5-filesystem, ncurses-base. problem c may not be fixed,
> releated ref: https://bugzilla.redhat.com/show_bug.cgi?id=790869
> Thanks for your good advice.
> 
> SPEC URL:
> https://download.copr.fedorainfracloud.org/results/topazus/test-review/
> fedora-rawhide-x86_64/05598415-contour-terminal/contour-terminal.spec
> SRPM URL:
> https://download.copr.fedorainfracloud.org/results/topazus/test-review/
> fedora-rawhide-x86_64/05598415-contour-terminal/contour-terminal-0.3.11.258-
> 1.fc39.src.rpm
> 
> review:
> https://download.copr.fedorainfracloud.org/results/topazus/test-review/
> fedora-rawhide-x86_64/05598415-contour-terminal/fedora-review/review.txt

Forgive my last comment and Here are detailed corrections with my last comment:
a): use rpm -qf to query what package owns the directories. ref:
https://stackoverflow.com/questions/30067649/rpmbuild-common-ownership-of-directories

solution: adding Requires of hicolor-icon-theme, kf5-kservice, kf5-filesystem,
ncurses-base

b): I have done this. Thanks for your advice.

c): It may not be fixed because there is a package named libunicode in my
BuildRequires, maybe the releated ref:
https://bugzilla.redhat.com/show_bug.cgi?id=790869

d): I enabled in my Copr. Thanks.

e): I see the upstream tests and modified my .spec file.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2174384
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux