[Bug 2174487] Review Request: esmi_ib_library - E-SMI: EPYC™ System management Interface In-band Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2174487

Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(davide@xxxxxxxxxx
                   |                            |me)



--- Comment #2 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> ---
the soversion is not actually 1.5.0.0, it seems to be 1.5? (with 1 as the major
version)

You should edit the %files section to avoid globbing, because now in the
(unlikely, granted) case upstream suddenly bumps to 10, we will not notice
because of the globbing

e.g. change this:

%{_libdir}/libe_smi64.so.1*

to 

%global major_version 1
%global minor_version 5
%global full_version %{major_version}.%{minor_version}.0.0

^ and use this in Version: and in the sed replacing get_version_from_tag

%{_libdir}/libe_smi64.so.%{major_version}
%{_libdir}/libe_smi64.so.%{major_version}.%{minor_version}


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174487
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux