[Bug 2174384] Review Request: contour-terminal - Modern C++ Terminal Emulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2174384



--- Comment #7 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
Problems pointed out by fedora-review:
a) Check installation procedure for these desktop file icons in another GUI
application:
     Note: Directories without known owners:
     /usr/share/kservices5/ServiceMenus,
     /usr/share/icons/hicolor/512x512/apps, /usr/share/terminfo,
     /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/128x128/apps,
     /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor,
     /usr/share/kservices5, /usr/share/icons/hicolor/32x32/apps,
     /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/64x64,
     /usr/share/terminfo/c, /usr/share/icons/hicolor/512x512,
     /usr/share/icons/hicolor/256x256/apps,
     /usr/share/icons/hicolor/64x64/apps
Perhaps see if upstream can modify:
https://github.com/contour-terminal/contour/blob/master/src/contour/CMakeLists.txt#L323
Maybe
https://cmake.org/cmake/help/latest/cpack_gen/rpm.html#cpack_gen:CPack%20RPM%20Generator
might also be helpful

b) Remove one of these and use a soft link
W: files-duplicate /usr/share/terminfo/c/contour-latest
/usr/share/terminfo/c/contour

c) Check/modify linking:
E: explicit-lib-dependency libunicode
Maybe ninja build will not do this?

d) You can run fedora-review in Copr:
https://frostyx.cz/posts/running-fedora-review-after-copr-build

e) Consider using Ninja as upstream tests with this:
https://github.com/contour-terminal/contour/blob/master/.github/fedora/contour.spec


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174384
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux