[Bug 2102388] Review Request: delve - Delve is a debugger for the Go programming language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2102388



--- Comment #25 from Andreas Schneider <asn@xxxxxxxxxx> ---
Looking at the build.log from a fedora-review run, it doesn't look like tests
are being executed:

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.pzbvFD
+ umask 022
+ cd /builddir/build/BUILD
+ cd delve-1.20.1
+ export GO111MODULE=off
+ GO111MODULE=off
+ export
GOPATH=/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode:/usr/share/gocode
+
GOPATH=/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode:/usr/share/gocode
+
delvepath=/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve
+ cp -r _fixtures
/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve
+ cp -r pkg/dwarf/line/_testdata
/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve/pkg/dwarf/line
+ pushd
/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve
~/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64/usr/share/gocode/src/github.com/go-delve/delve
~/build/BUILD/delve-1.20.1
++ go list ./...
++ grep -v cmd
++ grep -v scripts
pkg/proc/internal/ebpf/trace_bpfel_x86.go:125:12: pattern trace_bpfel_x86.o: no
matching files found
+ rm -rf
/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve/_fixtures
+ rm -rf
/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve/pkg/dwarf/line/_testdata
+ popd


The only indicator is that there is an error from a test, however the error
doesn't make %check fail!


$ go test -count=1 github.com/go-delve/delve/pkg/proc/internal/ebpf
pkg/proc/internal/ebpf/trace_bpfel_x86.go:125:12: pattern trace_bpfel_x86.o: no
matching files found
$ echo $?
1

(The test fails because trace_bpfel_x86.o isn't copied over.)

The loops seems to be problematic here! It hides the exit code of the test.
However we could just run it once with:

go list ./... | awk '!/(cmd|scripts)/ {print $1}' | xargs %{gotest}


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux