https://bugzilla.redhat.com/show_bug.cgi?id=2174383 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > BuildRequires: gcc-c++ cmake unzip > BuildRequires: range-v3-devel fmt-devel One per line, please. > pushd _ucd/ucd-%{ucd_version} > unzip %{SOURCE1} > popd 'unzip -d _ucd/ucd-%{ucd_version} %{SOURCE1}' ? Hmm, we already have the UCD available as unicode-ucd? Why not use that instead. Please provide some explanation what %SOURCE1 is used for. > %{_libdir}/%{name}*.so.* This glob is too generic. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files > libunicode-tools.x86_64: W: no-manual-page-for-binary unicode-query This would be nice-to-have, esp. that unicode-query just treats all arguments as stuff to query. > libunicode.x86_64: W: library-not-linked-against-libc /usr/lib64/libunicode_ucd.so.0.2.0 > 6 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.7 s Hmm. $ ldd /usr/lib64/libunicode_ucd.so.0.2.0 | rg libc libc.so.6 => /lib64/libc.so.6 (0x00007f16f5e21000) I think rpmlint got confused somehow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2174383 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue