https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review =========== > %global git_date %%(date +'%Y%m%d') This date needs to be fixed, not floating. Base it on the commit date. > Version: 0 > Release: 1.%{git_date}git%{shortcommit}%{?dist} Please use modern snapshot versioning. It'd look something like this: > Version: 0^%{git_date}git%{shortcommit} > Release: 1%{?dist} Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > Source: https://github.com/Joshua-Ashton/vkroots/archive/%{commit}/%{name}-%{shortcommit}.tar.gz The source can be simplified to "%{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz" > License: LGPL-2.1-only The license is "LGPL-2.1-or-later AND (Apache-2.0 or MIT)" -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
