https://bugzilla.redhat.com/show_bug.cgi?id=2173523 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #12 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* BSD 3-Clause License", "GNU Free Documentation License v1.3", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 3", "*No copyright* [generated file]". 152 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/qt6-qtspeech/2173523-qt6-qtspeech/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/cmake/Qt6Qml, /usr/lib64/cmake/Qt6Qml/QmlPlugins [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/qt6/examples(qt6-qtbase-examples, qt6-qtsensors-examples, qt6-qtdeclarative-examples, qt6-qtquick3d-examples, qt6-qtnetworkauth- examples, qt6-qt3d-examples, qt6-qtserialbus-examples, qt6-qtserialport-examples, qt6-qtremoteobjects-examples, qt6-qtdatavis3d-examples, qt6-qtsvg-examples, qt6-qtwebchannel- examples, qt6-qtcharts-examples, qt6-qtwebengine-examples, qt6-qtscxml-examples, qt6-qttools-examples, qt6-qtmultimedia-examples, qt6-qtpositioning-examples, qt6-qtconnectivity-examples, qt6-qtwebsockets-examples, qt6-qtvirtualkeyboard-examples) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: qt6-qtspeech-6.4.2-1.fc37.x86_64.rpm qt6-qtspeech-devel-6.4.2-1.fc37.x86_64.rpm qt6-qtspeech-examples-6.4.2-1.fc37.x86_64.rpm qt6-qtspeech-debuginfo-6.4.2-1.fc37.x86_64.rpm qt6-qtspeech-debugsource-6.4.2-1.fc37.x86_64.rpm qt6-qtspeech-6.4.2-1.fc37.src.rpm =============================================================== rpmlint session starts =============================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqnlt5cww')] checks: 31, packages: 6 qt6-qtspeech.x86_64: W: no-documentation qt6-qtspeech-devel.x86_64: W: no-documentation qt6-qtspeech-examples.x86_64: W: no-documentation qt6-qtspeech-devel.x86_64: W: files-duplicate /usr/lib64/cmake/Qt6TextToSpeech/Qt6TextToSpeechConfigVersionImpl.cmake /usr/lib64/cmake/Qt6Qml/QmlPlugins/Qt6TextToSpeechQmlConfigVersionImpl.cmake:/usr/lib64/cmake/Qt6TextToSpeech/Qt6QTextToSpeechFlitePluginConfigVersionImpl.cmake:/usr/lib64/cmake/Qt6TextToSpeech/Qt6QTextToSpeechMockPluginConfigVersionImpl.cmake:/usr/lib64/cmake/Qt6TextToSpeech/Qt6QTextToSpeechSpeechdPluginConfigVersionImpl.cmake ================================ 6 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 5.6 s ================================ Rpmlint (debuginfo) ------------------- Checking: qt6-qtspeech-examples-debuginfo-6.4.2-1.fc37.x86_64.rpm qt6-qtspeech-debuginfo-6.4.2-1.fc37.x86_64.rpm =============================================================== rpmlint session starts =============================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmb18b7kj')] checks: 31, packages: 2 ================================ 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 2.8 s ================================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6 qt6-qtspeech-devel.x86_64: W: no-documentation qt6-qtspeech.x86_64: W: no-documentation qt6-qtspeech-examples.x86_64: W: no-documentation qt6-qtspeech-devel.x86_64: W: files-duplicate /usr/lib64/cmake/Qt6TextToSpeech/Qt6TextToSpeechConfigVersionImpl.cmake /usr/lib64/cmake/Qt6Qml/QmlPlugins/Qt6TextToSpeechQmlConfigVersionImpl.cmake:/usr/lib64/cmake/Qt6TextToSpeech/Qt6QTextToSpeechFlitePluginConfigVersionImpl.cmake:/usr/lib64/cmake/Qt6TextToSpeech/Qt6QTextToSpeechMockPluginConfigVersionImpl.cmake:/usr/lib64/cmake/Qt6TextToSpeech/Qt6QTextToSpeechSpeechdPluginConfigVersionImpl.cmake 6 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 11.2 s Unversioned so-files -------------------- qt6-qtspeech: /usr/lib64/qt6/plugins/texttospeech/libqtexttospeech_flite.so qt6-qtspeech: /usr/lib64/qt6/plugins/texttospeech/libqtexttospeech_mock.so qt6-qtspeech: /usr/lib64/qt6/plugins/texttospeech/libqtexttospeech_speechd.so qt6-qtspeech: /usr/lib64/qt6/qml/QtTextToSpeech/libtexttospeechqmlplugin.so Source checksums ---------------- https://download.qt.io/official_releases/qt/6.4/6.4.2/submodules/qtspeech-everywhere-src-6.4.2.tar.xz : CHECKSUM(SHA256) this package : a9c99f8d34d6f500abf64c9aebdd41f01e746bcf54ff62ad006662400cb494cb CHECKSUM(SHA256) upstream package : a9c99f8d34d6f500abf64c9aebdd41f01e746bcf54ff62ad006662400cb494cb Requires -------- qt6-qtspeech (rpmlib, GLIBC filtered): libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.4)(64bit) libQt6Core.so.6(Qt_6_PRIVATE_API)(64bit) libQt6Multimedia.so.6()(64bit) libQt6Qml.so.6()(64bit) libQt6TextToSpeech.so.6()(64bit) libc.so.6()(64bit) libflite.so.1()(64bit) libspeechd.so.2()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) qt6-qtbase(x86-64) rtld(GNU_HASH) qt6-qtspeech-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) libQt6TextToSpeech.so.6()(64bit) pkgconfig(Qt6Core) qt6-qtbase-devel(x86-64) qt6-qtspeech(x86-64) qt6-qtspeech-examples (rpmlib, GLIBC filtered): libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.4)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6TextToSpeech.so.6()(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) qt6-qtspeech(x86-64) rtld(GNU_HASH) qt6-qtspeech-debuginfo (rpmlib, GLIBC filtered): qt6-qtspeech-debugsource (rpmlib, GLIBC filtered): Provides -------- qt6-qtspeech: libQt6TextToSpeech.so.6()(64bit) libqtexttospeech_flite.so()(64bit) libqtexttospeech_mock.so()(64bit) libqtexttospeech_speechd.so()(64bit) libtexttospeechqmlplugin.so()(64bit) qt6-qtspeech qt6-qtspeech(x86-64) qt6-qtspeech-devel: cmake(Qt6QTextToSpeechFlitePlugin) cmake(Qt6QTextToSpeechMockPlugin) cmake(Qt6QTextToSpeechSpeechdPlugin) cmake(Qt6TextToSpeech) cmake(Qt6TextToSpeechQml) cmake(QtSpeechTests) cmake(qt6qtexttospeechfliteplugin) cmake(qt6qtexttospeechmockplugin) cmake(qt6qtexttospeechspeechdplugin) cmake(qt6texttospeech) cmake(qt6texttospeechqml) cmake(qtspeechtests) pkgconfig(Qt6TextToSpeech) qt6-qtspeech-devel qt6-qtspeech-devel(x86-64) qt6-qtspeech-examples: qt6-qtspeech-examples qt6-qtspeech-examples(x86-64) qt6-qtspeech-debuginfo: debuginfo(build-id) libQt6TextToSpeech.so.6.4.2-6.4.2-1.fc37.x86_64.debug()(64bit) libqtexttospeech_flite.so-6.4.2-1.fc37.x86_64.debug()(64bit) libqtexttospeech_mock.so-6.4.2-1.fc37.x86_64.debug()(64bit) libqtexttospeech_speechd.so-6.4.2-1.fc37.x86_64.debug()(64bit) libtexttospeechqmlplugin.so-6.4.2-1.fc37.x86_64.debug()(64bit) qt6-qtspeech-debuginfo qt6-qtspeech-debuginfo(x86-64) qt6-qtspeech-debugsource: qt6-qtspeech-debugsource qt6-qtspeech-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/FedoraPackaging/reviews/qt6-qtspeech/2173523-qt6-qtspeech/srpm/qt6-qtspeech.spec 2023-03-03 08:01:17.661595702 +0300 +++ /home/FedoraPackaging/reviews/qt6-qtspeech/2173523-qt6-qtspeech/srpm-unpacked/qt6-qtspeech.spec 2023-02-27 12:15:47.000000000 +0300 @@ -8,8 +8,5 @@ Release: 1%{?dist} -# Code can be either LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only -# See e.g. src/plugins/speechdispatcher or src/tts -# Examples are under BSD-3-Clause -License: (GPL-2.0-only OR LGPL-3.0-only OR GPL-3.0-only WITH Qt-GPL-exception-1.0) AND BSD-3-Clause +License: LGPL-3.0-only OR GPL-3.0-only WITH Qt-GPL-exception-1.0 Url: http://www.qt.io %global majmin %(echo %{version} | cut -d. -f1-2) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2173523 -m fedora-37-x86_64 Buildroot used: fedora-37-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Ocaml, Java, Haskell, Python, R, fonts, SugarActivity, Ruby, Perl, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) When running on Fedora 37, still have directories without known owners: /usr/lib64/cmake/Qt6Qml /usr/lib64/cmake/Qt6Qml/QmlPlugins It is possible to co-own or require Qt6Qml: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package For rawhide, the copr build does not give any problems, though may want to add Requires: qt6-qtdeclarative b) Should the Qt license be packaged? Perhaps should package only licenses allowed in Fedora? c) Can the tests be optionally built and run? For the CMake config add -DQT_BUILD_TESTS=ON They cannot be heard on Koji. qvoice test may need additional configuration/engine to be useful. d) Perhaps bug should be raised on rpmlint for the license? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2173523 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
