[Bug 2175012] Review request: iwyu - A tool for use with clang to analyze #includes in C and C++ source files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2175012



--- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
Thanks for the feedback.
> 1) Why do you need to specify the LDFLAGS and the prefix path? Both those should be specified 
> by the Fedora build flags properly.
Without LDFLAG do not get a position independent executable. Prefix path is
suggested in install
docs.

> 2) I'd suggest modifying the way you exclude the assembly test to be by deleting the file in the
> prep section instead of modifying the configured CMake files. Additionally, it is more readable if
> you use a %ifnarch and just have one branch for the conditional.
Done

> 3) `BuildRequires:  python-devel` should be versioned, so it should be 
> `BuildRequires:  python3-devel` (according to the guidelines 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_distro_wide_guidelines)
Done

> 4) For F36 and newer, I don't think you need to specify the compilers to CMake directly,
> it should find clang using the CC and CXX environment variables set by RPM.
Done

> There is also a %clang_resource_dir macro you can use here instead.
Done

> Maybe using %autorelease and %autochangelog macro for packaging has some benefits.
Prefer to manage manually for the time being, commits do not all correspond to
changelog entries.

spec:
https://download.copr.fedorainfracloud.org/results/fed500/include-what-you-use/fedora-rawhide-x86_64/05588697-iwyu/iwyu.spec
srpm:
https://download.copr.fedorainfracloud.org/results/fed500/include-what-you-use/fedora-rawhide-x86_64/05588697-iwyu/iwyu-0.19-2.fc39.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175012
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux