[Bug 2102388] Review Request: delve - Delve is a debugger for the Go programming language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2102388



--- Comment #23 from Alejandro Sáez Morollón <asm@xxxxxxxxxx> ---
Thanks for taking the review. I changed the %{_bindir}/* to %{_bindir}/dlv.

Regarding the name, as we discussed through chat, delve is a well-known app so
it doesn't need to follow the go naming conventions:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_naming

Regarding the symlink, the test suite behaves in an unexpected way on ARM if I
use symlinks making several tests fail, hence the cp.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux