https://bugzilla.redhat.com/show_bug.cgi?id=2174227 --- Comment #4 from blinxen <h-k-81@xxxxxxxxxxx> --- Updated spec file and SRPM under: Spec URL: https://blinxen.fedorapeople.org/rust-imagequant-sys/rust-imagequant-sys.spec SRPM URL: https://blinxen.fedorapeople.org/rust-imagequant-sys/rust-imagequant-sys-4.0.1-1.fc37.src.rpm > 1. Superfluous License tag in the libimagequant-devel subpackage: Thanks for the example! Are the marcos documented somewhere? If not, where would be the best place to document it? > 2. The description says "dual-licensed like pngquant", but the license metadata is just "GPL-3.0-or-later". I think with dual-licensed the following is meant [1]: ``` Libimagequant is dual-licensed: For Free/Libre Open Source Software it's available under GPL v3 or later with additional copyright notices for older parts of the code. For use in closed-source software, AppStore distribution, and other non-GPL uses, you can obtain a commercial license. Feel free to ask kornel@xxxxxxxxxxxx for details and custom licensing terms if you need them. ``` That means that if someone wants to use this code in a non GPL-3.0-or-later compliant code then he could acquire a commercial license. At least that's why I understand the from the statement above. > 3. Is the ABI of "old" libimagequant (v2) the same as the one provided by the "new" one built in this package? I would assume that because rust (still?) has no stable ABI, the dependent packages will need to be rebuilt. > assuming the APIs are the same This is the diff between the main and 2.x branch: ``` > diff libimagequant_main.h libimagequant_2.h 16,17c16,17 < #define LIQ_VERSION 40000 < #define LIQ_VERSION_STRING "4.0.0" --- > #define LIQ_VERSION 21800 > #define LIQ_VERSION_STRING "2.18.0" 75c75 < LIQ_EXPORT LIQ_USERESULT liq_attr* liq_attr_create_with_allocator(void* removed, void *unsupported); --- > LIQ_EXPORT LIQ_USERESULT liq_attr* liq_attr_create_with_allocator(void* (*malloc)(size_t), void (*free)(void*)); ``` >From my limited C knowledge I would assume that this is ok? [1] https://github.com/ImageOptim/libimagequant#license -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2174227 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
