https://bugzilla.redhat.com/show_bug.cgi?id=2117349 Troy Curtis <troy@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |troy@xxxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |needinfo?(logans@xxxxxxxxxx | |t) --- Comment #2 from Troy Curtis <troy@xxxxxxxxxxxxxxxx> --- A few comments: The spec file should use the latest python macros, and specifically use .dist-info instead of egg-info https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dist_info_metadata The use of %{python3_pkgversion} shouldn't be necessary, it is typically to just specify for example: "python3-devel". The license should be SPDX formatted, and it looks like it should probably be "Apache-2.0". https://docs.fedoraproject.org/en-US/legal/license-field/ Ideally, build requires would use the generated dependencies https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros I'm not sure about the check "%if %{undefined __pythondist_requires}", but in Fedora is seems like the dependency generator should be used for this purpose. Is this because it is targeting epel as well? (I'm pretty unfamiliar with the needs of epel packages). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2117349 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
