[Bug 2119983] Review Request: c-icap - An implementation of an ICAP server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2119983



--- Comment #50 from Simone Caronni <negativo17@xxxxxxxxx> ---
(In reply to Frank Crawford from comment #49)
> Ahh, for this issue
> 
> > c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf
> 
> It looks like the standard fix would be to add into the %install section
> 
> > install -d -m 0755 %{buildroot}/run/%{name}/
> 
> and into the %files section
> 
> > %dir /run/%{name}/
> (probably with an attr to set the owner)
> 
> I should have read the full documentation better earlier.

Tried both, it did not help. So the warning comes from rpmlint, which checks
for the %tmpfiles_create macro. The %tmpfiles_create macros have been rejected
for the policy, and the macros.systemd file reports that %tmpfiles_create has
been replaced by %tmpfiles_create_package macro, which rpmlint would report as
a failure anyway.

Regarding %dir /run/%{name}/, I was already setting it as %ghost /run/%{name}/.
Both are fine, but I changed it back to %dir to follow the guidelines.

> As for the obsolete m4 macros, if they are too difficult at present, I'm
> willing to let them go, as long as we raise it upstream for a future fix. 
> After all, it is a "should not", not a "must not" issue.

I will open a bug for this as well, all the other rpmlint issues were fixed
upstream after reporting them.

Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec
SRPM URL:
https://slaanesh.fedorapeople.org/c-icap-0.5.11-9.20230220gitc5f2103.fc37.src.rpm

* Fri Feb 24 2023 Simone Caronni <negativo17@xxxxxxxxx> -
0.5.11-9.20230220gitc5f2103
- Update to latest snapshot.

https://github.com/scaronni/c-icap/commit/567581a424bd2d3308c18ad34fdf68a2cb02c546


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux