[Bug 2172053] Review Request: python-trove-classifiers - Canonical source for classifiers on PyPI (pypi.org).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2172053



--- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
1) the patch is modified and does not correspond to the patch URL:

--- 809156bb35852bcaa1c753e0165f1814f2bcedf6.patch.1    2023-02-21
17:59:20.638478801 +0100
+++ 809156bb35852bcaa1c753e0165f1814f2bcedf6.patch      2023-02-21
01:00:00.000000000 +0100
@@ -12,20 +12,6 @@
  delete mode 100644 setup.py
  create mode 100644 src/trove_classifiers/version.py

-diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
-index b11e366..d6b68a7 100644
---- a/.github/workflows/release.yml
-+++ b/.github/workflows/release.yml
-@@ -32,7 +32,8 @@ jobs:
-         password: ${{ secrets.pypi_password }}
-     - name: Version
-       id: version
--      run: echo "::set-output name=version::$(python setup.py --version
2>/dev/null)"
-+      run: |
-+        echo version=$(python -c "from trove_classifiers import version;
print(version.__version__)" 2>/dev/null) >> $GITHUB_OUTPUT
-     - name: Tag
-       uses: actions/create-release@v1
-       env:
 diff --git a/pyproject.toml b/pyproject.toml
 index 672fc13..23542a4 100644
 --- a/pyproject.toml
@@ -117,4 +103,4 @@
 --- /dev/null
 +++ b/src/trove_classifiers/version.py
 @@ -0,0 +1 @@
-+__version__ = "2022.12.22"
++__version__ = "2023.2.20"




2) the %check section is empty



3) W: summary-ended-with-dot Canonical source for classifiers on PyPI
(pypi.org).



4) %license LICENSE is duplicated:

$ rpm -qp --licensefiles python3-trove-classifiers-2023.2.20-1.fc39.noarch.rpm 
/usr/lib/python3.11/site-packages/trove_classifiers-2023.2.20.dist-info/LICENSE
/usr/share/licenses/python3-trove-classifiers/LICENSE


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2172053
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux