https://bugzilla.redhat.com/show_bug.cgi?id=2172238 Bug ID: 2172238 Summary: Review Request: golang-oras - Work with OCI registries, but for secure supply chain Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: davide@xxxxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: davide@xxxxxxxxxxxx, extras-qa@xxxxxxxxxxxxxxxxx, matt.hickford@xxxxxxxxx, package-review@xxxxxxxxxxxxxxxxxxxxxxx, zebob.m@xxxxxxxxx Depends On: 2140707 (golang-github-need-being-tree), 2140708 (golang-oras), 2140709 (golang-oras-2), 2172236, 2172237 Blocks: 2138839, 2138841 Target Milestone: --- Classification: Fedora +++ This bug was initially created as a clone of Bug #2140708 +++ Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-oras.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-oras-0.15.1-1.20221105git690716b.fc37.src.rpm Description: Work with OCI registries, but for secure supply chain - managing content like artifacts, images, SBOM. Fedora Account System Username: dcavalca --- Additional comment from M Hickford on 2022-11-13 17:16:24 UTC --- "not yet a packager and the review is thus unofficial" Is it necessary to include both BuildRequires and go_generate_buildrequires? BuildRequires: golang(oras.land/oras-go/v2) %generate_buildrequires %go_generate_buildrequires --- Additional comment from Davide Cavalca on 2023-01-17 05:39:46 UTC --- Taking this review --- Additional comment from Davide Cavalca on 2023-01-17 05:55:15 UTC --- This fails to build with No matching package to install: 'golang(github.com/need-being/go-tree)' --- Additional comment from Davide Cavalca on 2023-01-17 06:07:19 UTC --- I can confirm this does need the explicit BR on golang(oras.land/oras-go/v2) or it'll fail to build. --- Additional comment from Davide Cavalca on 2023-01-17 06:11:00 UTC --- Package was generated with go2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the package is packaged - license matches upstream specification and is acceptable for Fedora - license file is included - package complies with Golang Packaging Guidelines Package APPROVED. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2138839 [Bug 2138839] F38FailsToInstall: golang-github-deislabs-oras-devel https://bugzilla.redhat.com/show_bug.cgi?id=2138841 [Bug 2138841] F38FailsToInstall: golang-helm-3-devel https://bugzilla.redhat.com/show_bug.cgi?id=2140707 [Bug 2140707] Review Request: golang-github-need-being-tree - Pretty print trees in Go https://bugzilla.redhat.com/show_bug.cgi?id=2140708 [Bug 2140708] Review Request: golang-oras - Work with OCI registries, but for secure supply chain https://bugzilla.redhat.com/show_bug.cgi?id=2140709 [Bug 2140709] Review Request: golang-oras-2 - ORAS Go library https://bugzilla.redhat.com/show_bug.cgi?id=2172236 [Bug 2172236] Review Request: golang-github-need-being-tree - Pretty print trees in Go https://bugzilla.redhat.com/show_bug.cgi?id=2172237 [Bug 2172237] Review Request: golang-oras-2 - ORAS Go library -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2172238 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
