https://bugzilla.redhat.com/show_bug.cgi?id=2172068 --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- I can’t do the full review right now (I will get to it soon) but here are a couple of things I noticed from just looking at the spec file: - There is a BuildRequires on pytest-cov. Coverage tools like this should normally be patched out along with linters. You will have to remove the --cov* arguments from addopts in the [tool:pytest] section of setup.cfg for the tests to work without pytest-cov. - You shouldn’t need an explicit BR on python3dist(setuptools) - I am not convinced it makes sense to mark test code in %{python3_sitelib} as %doc. Also, given that it looks like these files are apparently installed but not listed in %{pyproject_files}, do you even want to install tests at all, even as a separate subpackage? Or would you rather just remove them from the buildroot? - In this case, %pyproject_files handles the license file, so you don’t need the explicit %license LICENSE. It’s always good to check this (rpm -qL -p ...) since it doesn’t always happen (depending on the license file name, build backend, and/or various upstream minutia). I’ll take a closer look as soon as I can. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2172068 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
