[Bug 2168858] Review Request: python-rapidfuzz - Rapid fuzzy string matching in Python and C++ using the Levenshtein Distance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2168858



--- Comment #18 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
(In reply to Karolina Surma from comment #17)
> I follow the discussion on packaging mailing list which may change the
> ultimate direction of this package, but just the two notes regarding the
> latest package.
> 
> 1) rapidfuzz.h and __init__.pxd are now present in both python3-rapidfuzz
> and python-rapidfuzz-devel, instead of just python-rapidfuzz-devel.
> 
> pyproject-rpm-files say: "Note that %pyproject_save_files uses data from the
> RECORD file. If you wish to rename, remove or otherwise change the installed
> files of a package after %pyproject_install, %pyproject_save_files might
> break. If possible, remove/rename such files in %prep. If not possible,
> avoid using %pyproject_save_files or edit/replace %{pyproject_files}." -
> maybe it would be enough to modify %{pyproject_files} not to contain the two
> files?

The advice is for removing files completely. To move them to a different
package, this should do:

%files -n python3-rapidfuzz -f %{pyproject_files}
%doc README.*
%exclude %{python3_sitearch}/rapidfuzz/rapidfuzz.h
%exclude %{python3_sitearch}/rapidfuzz/__init__.pxd

%files -n python3-rapidfuzz-devel
%{python3_sitearch}/rapidfuzz/rapidfuzz.h
%{python3_sitearch}/rapidfuzz/__init__.pxd


Also note that the devel package name should be python3-rapidfuzz-devel, not
python-rapidfuzz-devel -- rule of thumb: it installs files to
%{python3_sitearch}.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2168858
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux