[Bug 2169277] Review Request: braille-printer-app - Braille printer application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2169277

Zdenek Dohnal <zdohnal@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(benson_muite@emai
                   |                            |lplus.org)



--- Comment #18 from Zdenek Dohnal <zdohnal@xxxxxxxxxx> ---
(In reply to Benson Muite from comment #17)
> Installed this on a rawhide VM
> 
> $ sudo dnf update
> $ sudo dnf install wget
> $ wget
> https://download.copr.fedorainfracloud.org/results/fed500/braille-printer-
> app/fedora-rawhide-aarch64/05537922-braille-printer-app/braille-printer-app-
> 2.0b0%5E386eea385f-1.fc39.aarch64.rpm
> $ sudo dnf install
> ./'braille-printer-app-2.0b0^386eea385f-1.fc39.aarch64.rpm'
> $ echo "An example sentence" > test.txt
> $ sudo systemctl enable cups
> $ sudo systemctl start cups
> $ lpadmin -p ubrl -v cups-brf:/ -m drv:///generic-ubrl.drv/gen-ubrl.ppd
> $ lpadmin -p ubrl -E
> $ lp -d ubrl test.txt
> lp: Unsupported document-format "text/plain".

That seems to be expected based on provided braille.convs - there is no
conversion defined for text/plain to cups-ubrl, only for images. I've tested it
with /usr/share/cups/ipptool/testfile.jpg.gz (after I applied the fix mentioned
further down):

$ lp -d ubrl /usr/share/cups/ipptool/testfile.jpg.gz

CUPS DEBUG LOG:
Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]:
[Job 9] Set job-printer-state-message to "Ready", current level=INFO
Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]:
[Job 9] PID 17521 (/usr/lib/cups/filter/imagetoubrl) exited with no errors.
Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]:
[Job 9] PID 17522 (/usr/lib/cups/backend/cups-brf) exited with no errors.
Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]:
ubrl root 9 [19/Feb/2023:04:25:26 -0500] total 0 - localhost testfile.jpg.gz -
-
Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]:
[Job 9] time-at-completed=1676798726
Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]:
[Job 9] Job completed.

> $ lpadmin -p brf -v cups-brf:/ -m drv:///generic-brf.drv/gen-brf.ppd
> $ lpadmin -p brf -E
> $ lp -d brf test.txt
> $ lpstat -o
> brf-1                  fedora            1024   Sat 18 Feb 2023 11:20:04 AM
> UTC
> JOB DOES NOT COMPLETE
> $ sudo /usr/sbin/cupsfilter -m application/vnd.cups-brf -p
> /etc/cups/ppd/brf.ppd test.txt > ~/test.brf
> $ sudo /usr/sbin/cupsfilter -m application/vnd.cups-brf -p
> /etc/cups/ppd/ubrl.ppd test.txt > ~/test.ubrl
> 
> 
> Using sudo on /usr/sbin/cupsfilter produces output.  However lp -d seems not
> to work.  Probably an error in my setup, and not a blocker, but let me know
> if have any suggestions.

This is result of wanting to comply with rpmlint against the past experience -
it was caused by cups-brf being run as 'lp' user (which is a default user CUPS
runs its executables with due security reasons, if permissions allow it)
instead of root, so backend automatically failed. I've changed the permissions
to 0744, which complies with FPG ("File must be universally readable (and
executable if appropriate)" - which isn't in our case for 'group' and 'others'
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions)
but rpmlint will complain - but IMHO that's a bug in rpmlint which doesn't
match with FPG.

Additionally I've found out removing the musicxmltobrf filter causes cupsd to
report a missing filter, because braille defines conversions and data type for
it - I've written a configure option to disable musicxml support in
braille-printer-app and sent upstream - we won't ship a broken filter (due
missing FreeDots) if the musicxml support is disabled and CUPS doesn't report
missing filter because the braille MIME database was adjusted as well.

I've uploaded a new set of spec and srpm - would you mind giving review+ ?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2169277
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux