[Bug 2169846] Review Request: python-moddb - ModDB Reader for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2169846



--- Comment #5 from Chris King <bunnyapocalypse@xxxxxxxxxxxxxx> ---
Hey Thanks for the further feedback.

Regarding whether I ran mock on this, I did. I must've somehow not seen that it
failed last night... Don't ask me how, probably has something to do with being
tired...

Regardless. I've reworked the package to your suggestions with the exception of
the test suite. Many of the tests rely on having a username and password for
moddb in your os environment and I'm not aware of any way to safely do that in
Fedora's build process.

Perhaps I could patch out all tests relating to that, but I'd imagine that's
the large bulk of them...

As last time, the SRPM and SPEC are now updated.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2169846
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux