https://bugzilla.redhat.com/show_bug.cgi?id=2143050 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@xxxxxxxxxx --- Comment #3 from Petr Menšík <pemensik@xxxxxxxxxx> --- I think variables passed to build must include also LDFLAGS: CFLAGS="%{optflags} -fPIC" LDFLAGS="$LDFLAGS -shared -fPIC" And I think %check should also include unit test present in sources: %check export LUA_CPATH=%{buildroot}%{lua_libdir}/zlib.so lua -e 'local zlib = require "zlib"; print(zlib.version());' lua test.lua Otherwise it seems ready. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2143050 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
